Open
Conversation
lhearachel
reviewed
Mar 2, 2026
lhearachel
reviewed
Mar 4, 2026
include/appearance.h
Outdated
| int Appearance_CalculateFromTrainerInfo(u32 trainerId, int trainerGender, u32 variant); | ||
| int Appearance_GetIndex(int gender, int appearance); | ||
| int Appearance_GetTrainerClass(int gender, int appearance, int param2); | ||
| int Appearance_GetData(int gender, int appearance, int param2); |
Collaborator
There was a problem hiding this comment.
polish: Use enum AppearanceData for the final param, and also name it.
It would also be nice to go ahead and decorate calls to this function with the appropriate enum member-constant, but that's optional.
include/appearance.h
Outdated
| #include "string_template.h" | ||
|
|
||
| enum AppearanceData { | ||
| APPEARANCE_DATA_INDEX, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR documents
unk_0205C980.c(nowappearance.c) and some relatedScrCmds. These handle setting and getting the appearance for the player in the union room.